go/oasis-node/cmd/common: Fix isNodeRunning function#6520
Merged
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6520 +/- ##
==========================================
+ Coverage 63.36% 63.70% +0.34%
==========================================
Files 698 698
Lines 68297 68299 +2
==========================================
+ Hits 43275 43511 +236
+ Misses 20052 19816 -236
- Partials 4970 4972 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
peternose
approved these changes
May 4, 2026
martintomazic
force-pushed
the
martin/bugfix/is-node-running
branch
from
771b15b to
6a3b823
Compare
peternose
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Storage commands gated by this check are sometimes blocked due to the stale internal socket. This has now also surfaced in the e2e test I was writing about offline pruning/compaction.
How to test locally
A non-graceful shutdown of the node tends to keep stale
internal.sock.Observation
Seem that
internal.sockis sometimes not cleaned even with graceful shutdown. Meaning a possible bug during shutdown/cleanup (out of scope).